Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generic invoke failed for triple #13442

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fix generic invoke failed for triple #13442

merged 1 commit into from
Dec 1, 2023

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Nov 30, 2023 •
edited
Loading

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

44.4% 44.4% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ac2eaa) 69.47% compared to head (7aa1e4f) 69.46%.

Additional details and impacted files 
@@             Coverage Diff              @@
##                3.2   #13442      +/-   ##
============================================
- Coverage     69.47%   69.46%   -0.02%     
  Complexity        2        2              
============================================
  Files          1653     1653              
  Lines         71634    71626       -8     
  Branches      10270    10270              
============================================
- Hits          49768    49754      -14     
- Misses        17157    17167      +10     
+ Partials       4709     4705       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AlbumenJ added a commit to AlbumenJ/dubbo-samples that referenced this pull request Nov 30, 2023
@AlbumenJ
Add test cases to verify apache/dubbo#13442
a38dfaf
EarthChen
EarthChen approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit d552cfc into apache:3.2 Dec 1, 2023
14 checks passed
This was referenced Dec 8, 2023
Closed
Closed
AlbumenJ added a commit to apache/dubbo-samples that referenced this pull request Dec 14, 2023
@AlbumenJ
Add test cases to verify apache/dubbo#13441 (#1028)
c6a7049 
* Add test cases to verify apache/dubbo#13442

* Add test cases to verify apache/dubbo#13441

* Fix headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EarthChen EarthChen EarthChen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3.2.7 invoking remote service in generic mode causes java.lang.ClassNotFoundException
3 participants
@AlbumenJ @codecov-commenter @EarthChen